Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2978 Fix server-selection/tests/logging/operation-id.json:Failed client bulkWrite operation: log messages have operationIds #1659

Merged
merged 1 commit into from
Sep 17, 2024
Merged

DRIVERS-2978 Fix server-selection/tests/logging/operation-id.json:Failed client bulkWrite operation: log messages have operationIds #1659

merged 1 commit into from
Sep 17, 2024

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale commented Sep 16, 2024 •
edited
Loading

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@stIncMale
DRIVERS-2978 Fix `server-selection/tests/logging/operation-id.json:Fa…
4d23cb2 
…iled client bulkWrite operation: log messages have operationIds`
@stIncMale stIncMale self-assigned this Sep 16, 2024
@stIncMale stIncMale requested a review from a team as a code owner September 16, 2024 21:40
@stIncMale stIncMale requested review from vector-of-bool and removed request for a team September 16, 2024 21:40
@stIncMale stIncMale mentioned this pull request Sep 16, 2024
Merged
kevinAlbs
kevinAlbs approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. LGTM. I did not run test as C does not-yet implement the logging spec.

@kevinAlbs kevinAlbs removed the request for review from vector-of-bool September 17, 2024 14:35
@stIncMale stIncMale removed the request for review from isabelatkinson September 17, 2024 14:48
@stIncMale stIncMale merged commit fe4ba17 into mongodb:master Sep 17, 2024
4 checks passed
@stIncMale stIncMale deleted the DRIVERS-2978 branch September 17, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

Assignees

@stIncMale stIncMale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stIncMale @kevinAlbs