DRIVERS-2968 Relax index type requirements in bulk write spec #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
requested review from
nbbeeken,
kevinAlbs and
stIncMale
and removed request for
a team and
nbbeeken
kevinAlbs
approved these changes
Sep 18, 2024
stIncMale
approved these changes
Sep 18, 2024
jmikola
reviewed
Sep 20, 2024
| The `insertResults`, `updateResults`, and `deleteResults` maps in `BulkWriteResult` and the `writeErrors` map in | ||
| `BulkWriteException` specify `Index` as their key type. This value corresponds to the index of the operation in the | ||
| `writeModels` list that was provided to `MongoClient.bulkWrite`. Drivers SHOULD use their language's standard numeric | ||
| type for indexes for this type (e.g. `usize` in Rust). If no standard index type exists, drivers MUST use `Int64`. |
There was a problem hiding this comment.
Why did this only come up in the Bulk Write spec? Would it make sense to amend the CRUD spec as well?
IIRC, Rust never implemented the old bulk write API. Did you not come across this with InsertManyResult?
There was a problem hiding this comment.
See this thread: https://mongodb.slack.com/archives/C035ZJL6CQN/p1724787735885729
It probably makes sense to update CRUD as well, although drivers probably won't make any changes to those types at this point. Rust already deviates from the spec and uses usize in InsertManyResult. Filed DRIVERS-2983.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
clusters, and serverless).