Regenerate all JSON tests #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
requested review from
jmikola and
a team
and removed request for
a team and
jmikola
joshbsiegel
approved these changes
Sep 24, 2024
I think the idea of that script is to ensure that tests are updated after running locally. I'd like to take a look at that separately. |
isabelatkinson
pushed a commit
to isabelatkinson/specifications
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an issue introduced in #1660. By using
make -Bwe can unconditionally make all targets, meaning that file modification times don't come into effect. This should catch issues as the one in #1660, as re-runningmakewithout modifying the original YAML file did not yield an updated JSON file.This also resulted in two additional JSON tests being updated with changes introduced a while back.