DRIVERS-2124: test that inserts and upserts respect null _id values #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Oct 30, 2024
jmikola
reviewed
Oct 30, 2024
jmikola
reviewed
Oct 30, 2024
jmikola
reviewed
Oct 30, 2024
…d anchors, use flow syntax
jmikola
approved these changes
Oct 31, 2024
Comment on lines
+7
to
+8
| observeEvents: | ||
| - commandStartedEvent |
There was a problem hiding this comment.
Suggested change
| observeEvents: | |
| - commandStartedEvent |
Looks like you got rid of APM assertions.
There was a problem hiding this comment.
I figured the result of count is the source of truth now since we are able to use a BSON type query avoiding any comparison looseness surrounding null/undefined. But happy to add it back, just saying it was intentional to remove.
There was a problem hiding this comment.
countDocuments seems sufficient. APM assertions don't help if we have to worry about how some drivers represent null/undefined values.
jmikola
reviewed
Nov 1, 2024
| arguments: {filter: *null_id_filter} | ||
| expectResult: 1 | ||
|
|
||
| - description: inserting _id with type undefined via insertOne |
There was a problem hiding this comment.
Note: I'm removing these tests in #1713 as the server prohibits undefined values for _id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
[ ] Update changelog.N/Aclusters, and serverless).
Description
Adds tests for null and undefined as
_idvalues to check that drivers do not interpret these types as "unset" and generate an ObjectId and overwrite the value.