DRIVERS-1555: Test that isClientError considers network errors #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
requested review from
alcaeus,
aditi-khare-mongoDB and
nbbeeken
and removed request for
a team
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Nov 4, 2024
jmikola
commented
Nov 4, 2024
| commandName: ping | ||
| command: { ping: 1 } | ||
| expectError: | ||
| isClientError: true |
There was a problem hiding this comment.
Note: per DRIVERS-1555, at least the Go driver will require test runner changes to pass this assertion.
nbbeeken
approved these changes
Nov 4, 2024
|
Likewise for the PHPLIB POC. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DRIVERS-1555
Please complete the following before merging:
POC: mongodb/mongo-php-library#1520