DRIVERS-2781 Add option to configure DEK cache lifetime #1730
+1,818
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriandole
force-pushed
the
key-cache
branch
from
9903016
to
44b7329
Compare
jmikola
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Note: I only reviewed the unified-test-format changes. I'll defer to @katcharov on the CSFLE tests.
kevinAlbs
reviewed
Nov 13, 2024
kevinAlbs
approved these changes
Nov 20, 2024
Uint64 API Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
By default, libmongocrypt caches data encryption keys for one minute. Customers have reported that this duration can be too short and cause excessive traffic for fetching DEKs. This PR adds an option to set the cache expiration time.
Contents
Adds explicit encryption (legacy) and auto encryption (unified) tests.