Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct boolean values and exclude archived results from search #7436

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from

Conversation

mattstein
Copy link

This PR makes two changes to API search results:

  1. It ensures is_active and is_dead values are accurate, instead of always being cast to false because they’re absent from the $return_from_search set and never passed along.
  2. It limits results to those where is_active = true so that archived contacts are excluded.

I was surprised to find archived contacts in the results, but I can understand if item 2 is too opinionated since there are otherwise no other filters applied to that search. No problem removing and doing that client side if you’d rather!

Tested locally to confirm both work as expected.

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants