Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add -e flag for go list to fix build issues #34

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

adinhodovic
Copy link
Contributor

@adinhodovic adinhodovic commented Nov 6, 2023

Think this will fix building, would like to add a mixin or two but my git diff is to large since main builds are failing.

Installing tools from hack/tools.go
tools.go:8:2: import "github.com/brancz/gojsontoyaml" is a program, not an importable package

golang/go#61857 (comment)

@adinhodovic
Copy link
Contributor Author

@paulfantom can you take a look when you find time? Thanks!

@halkeye
Copy link

halkeye commented Feb 19, 2024

I wish I saw this before I did all the investigation to #38

(maybe update the title so @paulfantom realizing its fixing the build, not just because you want to)

@adinhodovic adinhodovic changed the title build: Add -e flag for go list build: Add -e flag for go list to fix build issues Mar 29, 2024
@v-zhuravlev
Copy link
Contributor

Hi1 Any update on this? I think fix is rather straightforward? thanks

@rgeyer
Copy link
Contributor

rgeyer commented Oct 24, 2024

I wish I saw this before I did all the investigation to #38

(maybe update the title so @paulfantom realizing its fixing the build, not just because you want to)

@halkeye does this supersede #38, or is the golang version update also necessary? I'm testing now with this PR and seems to be working. I'll merge after a successful check/testrun. Can you close, or resolve the conflict(s) on #38 after that?

@rgeyer rgeyer merged commit c98f013 into monitoring-mixins:master Oct 24, 2024
4 checks passed
@halkeye
Copy link

halkeye commented Oct 24, 2024

@rgeyer I don't think the golang upgrade is a requirement, it was 6 months ago though. That being said, I usually like the idea of upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants