An improved way of preserving and replaying original mappings #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain mappings, such as scrolling in floating windows, try to be non-intrusive, and when they can't be applied they use nvim_feedkeys() to replay the original mapping. However, this simple approach does not always work. For example, I have <C-n> remapped to gt which stops working and instead scrolls by a single line even when there are no floating windows. This change brings a more sophisticated mechanism of capturing and replaying the original mapping. The implementation was inspired by anuvyklack/keymap-amend.nvim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain mappings, such as scrolling in floating windows, try to be non-intrusive, and when they can't be applied they use nvim_feedkeys() to replay the original mapping.
However, this simple approach does not always work. For example, I have remapped to gt which stops working and instead scrolls by a single line even when there are no floating windows.
This change brings a more sophisticated mechanism of capturing and replaying the original mapping. The implementation was inspired by anuvyklack/keymap-amend.nvim