Fix REPL window opening in a redundant split #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are multiple tabs where each has its own REPL window (sharing the same buffer), then an issue occurs that opens a new split with a REPL window instead of reusing an existing one. This occurs because there is always only one "main window" which has a single associated REPL window, and there is no code that recalculates the current REPL window when the main one changes (e.g, when switching tabs). This change adds specific behaviour for REPL windows to try and reuse existing ones in the current tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are multiple tabs where each has its own REPL window (sharing the same buffer), then an issue occurs that opens a new split with a REPL window instead of reusing an existing one. This occurs because there is always only one "main window" which has a single associated REPL window, and there is no code that recalculates the current REPL window when the main one changes (e.g, when switching tabs).
Steps to reproduce:
This change adds specific behaviour for REPL windows to try and reuse existing ones in the current tab.