Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate best practices page #85

Merged
merged 18 commits into from
Dec 11, 2024
Merged

feat: translate best practices page #85

merged 18 commits into from
Dec 11, 2024

Conversation

Baroshem
Copy link

@Baroshem Baroshem commented Dec 5, 2024

Description of Problem

Proposed Solution

Additional Information

@Baroshem Baroshem marked this pull request as ready for review December 10, 2024 11:49
@Baroshem Baroshem requested a review from szymonlicau December 10, 2024 11:49
@Baroshem Baroshem linked an issue Dec 10, 2024 that may be closed by this pull request
4 tasks
Copy link
Collaborator

@szymonlicau szymonlicau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very comprehensive work - good job! 👍

I left some corrections and small suggestions over some wording styles or to maybe keep some definitions in english.

Let me know what you think 😄

src/guide/best-practices/performance.md Outdated Show resolved Hide resolved

### Bundle Size and Tree-shaking {#bundle-size-and-tree-shaking}
### Wielkość pakietu i potrząsanie drzewami {#bundle-size-and-tree-shaking}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd leave it as Tree-shaking instead especially since we name it so below 🤔 WDYT?


### Code Splitting {#code-splitting}
### Podział kodu {#code-splitting}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I'd leave it as Code Splitting and then start the next sentence as "Code splitting" - tzw Podział kodu... 🤔

src/guide/best-practices/performance.md Outdated Show resolved Hide resolved
src/guide/best-practices/performance.md Outdated Show resolved Hide resolved
src/guide/best-practices/security.md Outdated Show resolved Hide resolved
src/guide/best-practices/production-deployment.md Outdated Show resolved Hide resolved
src/guide/best-practices/production-deployment.md Outdated Show resolved Hide resolved
src/guide/best-practices/accessibility.md Outdated Show resolved Hide resolved
src/guide/best-practices/accessibility.md Outdated Show resolved Hide resolved
Baroshem and others added 12 commits December 10, 2024 16:02
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
src/guide/best-practices/performance.md Outdated Show resolved Hide resolved
src/guide/best-practices/performance.md Outdated Show resolved Hide resolved
@Baroshem Baroshem requested a review from szymonlicau December 10, 2024 15:09
Copy link
Collaborator

@szymonlicau szymonlicau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Baroshem Baroshem merged commit d27b353 into main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs > Guide > Best Practices] pages translation
2 participants