-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: translate best practices page #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very comprehensive work - good job! 👍
I left some corrections and small suggestions over some wording styles or to maybe keep some definitions in english.
Let me know what you think 😄
|
||
### Bundle Size and Tree-shaking {#bundle-size-and-tree-shaking} | ||
### Wielkość pakietu i potrząsanie drzewami {#bundle-size-and-tree-shaking} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd leave it as Tree-shaking
instead especially since we name it so below 🤔 WDYT?
|
||
### Code Splitting {#code-splitting} | ||
### Podział kodu {#code-splitting} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I'd leave it as Code Splitting
and then start the next sentence as "Code splitting" - tzw Podział kodu...
🤔
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
Co-authored-by: Szymon Licau <78469990+szymonlicau@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of Problem
Proposed Solution
Additional Information