-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate moonworm tasks #919
Conversation
|
||
entries_tags.append( | ||
{ | ||
"entry_id": task.entry_url.split("/")[-1], ## 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need entry id in tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It request for https://github.com/bugout-dev/spire/blob/171b6eb0f8ce9656308a4112deab76af59f662ea/spire/journal/api.py#L1772 that endpoint which get entries_ids and tags as array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
Currently we have posibility of dublicate events tasks in moonworm journal because hash deduplicate logic can be broke on different names of variables.
So we adding deduplication on function/event selectors logic.
For be sure what all moonworm tasks have selectors we will add selector tag on each entry
Output:
For chek if we have duplicates in moonworm tasks journal for some of abi and selector for particular address we will run deuplication migration.
Output:
command:
Output: