Leaderboard metadata #968
Merged
Leaderboard metadata #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kompotkot
reviewed
Nov 16, 2023
engineapi/engineapi/data.py
Outdated
| @@ -370,6 +380,10 @@ class Leaderboard(BaseModel): | |||
| title: str | |||
| description: Optional[str] = None | |||
| resource_id: Optional[UUID] = None | |||
| public: Optional[bool] = False | |||
| wallet_connect: Optional[bool] = False | |||
| blockchain_ids: Optional[List[int]] = None | |||
There was a problem hiding this comment.
Maybe better to store as empty list [] instead of None?
There was a problem hiding this comment.
Same for Optional[List[int]] = None below
There was a problem hiding this comment.
because default in postgres default=[]
| @@ -346,6 +347,11 @@ class Leaderboard(Base): # type: ignore | |||
| title = Column(VARCHAR(128), nullable=False) | |||
| description = Column(String, nullable=True) | |||
| resource_id = Column(UUID(as_uuid=True), nullable=True, index=True) | |||
| blockchain_ids = Column(ARRAY(Integer), nullable=False, default=[]) | |||
There was a problem hiding this comment.
I sugest also add sort for add and update values to this list, so it always will be readable, for example when query returns few result:
id blockchain_ids
<uuid1> 80001, 1
<uuid2> 1, 80001
Andrei-Dolgolev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaderboards db model was extended by additional fields
blockchain_ids- array of ids which blockchain that leaderboard includewallet_connect- show metamask connect on leaderboard (in case if address field is wallet address)columns_names- dict of mapping for column names if it not empty then will use LeaderboardUnformattedPosition reponse model.new model:
If used that model client must look in columns_names of leaderboard/info endpoint for get correct names of each fields as well as extract keys.
If use change just 1 field
columns_names : {"address": "token_id}then column_names will transform to that structure.Testing requests.
GET leaderboards Authorized Endpoints
Create Leaderboard Authorized Endpoints
Get scores
Update leaderboard endpoint
Get scores
Push scores
Get scores
Quartiles
Position
Rank
Ranks
Migration plan
merge that PR.
Run engine api deployment.