use XString rather than B when possible #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddr
reviewed
Oct 20, 2020
toddr
approved these changes
Oct 20, 2020
B has a rather large memort footprint, and we don't need most of what it provides. We only need the perlstring function. Refactor our conditionals to just have a _perlstring function, setting it up at compile time. For 5.10.0, just always use our reimplementation to simplify things. Add some comments to explain the logic.
Move quotify tests for alternate perl versions out of t, since they aren't relevant to normal users. Refactor setup in quotify tests to make it easier to initialize different environments.
|
looks like it needs a rebase but is otherwise fine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.