Fix bug 1342 #1348
Open
Fix bug 1342 #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
reviewed
Feb 5, 2017
Specs/Types/Date.js
Outdated
| @@ -424,6 +424,9 @@ describe('Date', function(){ | |||
| it('should return the minutes as two digits', function(){ | |||
| expect(d.format('%M')).toEqual('02'); | |||
| }); | |||
| it('should return the month as one digit', function(){ | |||
| expect(d.format('%n')).toEqual('11'); | |||
There was a problem hiding this comment.
This test is not really suitable to test %n, is it? You should pick a month < 10 and make sure there is no leading 0.
There was a problem hiding this comment.
I should get some more coffee before my first commits on sundays... ;-)
Thx. Fixed.
ghost
approved these changes
Jul 5, 2017
leofeyer
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #1342 by adding suggested code by @leofeyer contao/core@094e809#diff-8d2a0620105360ee4698532805680d5d plus specs.