Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Intelcom Shipper #1024

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

glbailey
Copy link

@glbailey glbailey commented Dec 1, 2024

fix: Update Intelcom Shipper email info

Proposed change

Intelcom created new shipper division called Dragonfly and changed all their email info. This fix adds the new email info.

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Intelcom changed its name to Dragonfly and updated email notifications.
@firstof9
Copy link
Collaborator

firstof9 commented Dec 1, 2024

Please format with black

@firstof9 firstof9 added code-quality Improves code quality or adds/updates tests work-in-progress shipper Request to add/modify a shipper labels Dec 1, 2024
@glbailey
Copy link
Author

glbailey commented Dec 1, 2024

OK, I ran Black on the file and did a commit. Can't figure out how to get rid of the first commit though.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.46%. Comparing base (8608d22) to head (d28a054).
Report is 49 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1024      +/-   ##
==========================================
- Coverage   95.07%   93.46%   -1.62%     
==========================================
  Files           8        8              
  Lines        1482     1606     +124     
==========================================
+ Hits         1409     1501      +92     
- Misses         73      105      +32     
Files with missing lines Coverage Δ
custom_components/mail_and_packages/const.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@firstof9
Copy link
Collaborator

firstof9 commented Dec 2, 2024

Thanks!

@firstof9 firstof9 merged commit 3c95c7d into moralmunky:dev Dec 2, 2024
5 checks passed
@firstof9 firstof9 added enhancement Changes that reduce code complexity or speed things up and removed code-quality Improves code quality or adds/updates tests labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that reduce code complexity or speed things up shipper Request to add/modify a shipper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants