Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Walmart delivered search #1029

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

derpderpington
Copy link

@derpderpington derpderpington commented Dec 6, 2024

Updated Walmart deliveries to include "Arrived:"

Proposed change

Update Walmart's list of delivery subjects keywords.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

I have over 25 delivery notifications and only 9 use the keyword "Delivered;" the other 16 are using the new proposed "Arrived:"

Updated Walmart deliveries to include "Arrived:"
@derpderpington derpderpington changed the title Update const.py perf: Update const.py Dec 6, 2024
@firstof9 firstof9 changed the title perf: Update const.py fix: update Walmart delivered search Dec 6, 2024
@firstof9 firstof9 added code-quality Improves code quality or adds/updates tests shipper Request to add/modify a shipper labels Dec 6, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.03%. Comparing base (8608d22) to head (0d16faa).
Report is 55 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1029      +/-   ##
==========================================
- Coverage   95.07%   93.03%   -2.05%     
==========================================
  Files           8        8              
  Lines        1482     1607     +125     
==========================================
+ Hits         1409     1495      +86     
- Misses         73      112      +39     
Files with missing lines Coverage Δ
custom_components/mail_and_packages/const.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@firstof9
Copy link
Collaborator

firstof9 commented Dec 6, 2024

Thanks!

@firstof9 firstof9 merged commit fcf6ad4 into moralmunky:dev Dec 6, 2024
7 of 8 checks passed
@derpderpington derpderpington deleted the patch-1 branch December 7, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Improves code quality or adds/updates tests shipper Request to add/modify a shipper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants