Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use homeassistant network helper to set image url sensor #1046

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

gpeavy
Copy link

@gpeavy gpeavy commented Jan 2, 2025

Proposed change

Use homeassistant network helper to set image url sensor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@gpeavy gpeavy changed the title Use homeassistant network helper to set image url sensor fix: Use homeassistant network helper to set image url sensor Jan 2, 2025
@firstof9 firstof9 added bugfix Pull request to fix a bug needs-tests Needs test(s) or updates to existing tests labels Jan 2, 2025
@firstof9
Copy link
Collaborator

firstof9 commented Jan 2, 2025

Please add tests to confirm get_url works as expected.

@gpeavy
Copy link
Author

gpeavy commented Jan 2, 2025

Please add tests to confirm get_url works as expected.

Here is the test from home-assistant/core for get_url:
https://github.com/home-assistant/core/blob/25937d786827d4ad8526dbbda3336dbac31f56a1/tests/helpers/test_network.py#L481-587

I'll look into the failed test.

@firstof9
Copy link
Collaborator

firstof9 commented Jan 2, 2025

Here is the test from home-assistant/core for get_url

Excellent, we'll just want to adjust the integration tests to work similar to the tests in core. Shouldn't be too rough. 🙂

Thanks for your contribution as well.

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-pr-activity Stale PR label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request to fix a bug needs-tests Needs test(s) or updates to existing tests work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants