Test toc_pdf_url, make creating link more readable

moravianlibrary · May 22, 2024 · 4eacc2b · 4eacc2b
1 parent b651a1b
commit 4eacc2b
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/module/VuFind/src/VuFind/Content/TOC/ObalkyKnih.php b/module/VuFind/src/VuFind/Content/TOC/ObalkyKnih.php
@@ -69,10 +69,9 @@ public function loadByIsbn($key, \VuFindCode\ISBN $isbnObj)
         ];
         $data = $this->service->getData($ids);
         $toc = '';
-        if (isset($data->toc_thumbnail_url)) {
-            $toc = "<p><a href='" . htmlspecialchars($data->toc_pdf_url)
-                . "' target='_blank' ><img src='"
-                . htmlspecialchars($data->toc_thumbnail_url) . "'></a></p>";
+        if (isset($data->toc_thumbnail_url) && isset($data->toc_pdf_url)) {
+            $toc = '<p><a href="%s" target="_blank" ><img src="%s"></a></p>';
+            $toc = sprintf($toc, htmlspecialchars($data->toc_pdf_url), htmlspecialchars($data->toc_thumbnail_url));
         }
         return $toc;
     }