Zip refactoring #715
Open
Zip refactoring #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To improve the documentation, we may get a lesson from System.Linq.Enumerable.Zip method. |
Closed
- introduce CustomZip with separate behavior by source - use CustomZip for EquiZip, ZipLongest and ZipShortest - add ValueTuple overloads - use t4 file to have up to 8 input sequences.
Remove "Source" from the name of the Zip method parameters. Typos
Fix spacing in tt files Renamed ZipLongestHelper.MoveNextOrDispose to Enumerator.Read
In Enumerator.TryRead value is now out instead of ref. Rewrite the Zip* sections in README.md
Co-Authored-By: Atif Aziz <code@raboof.com>
Added missing ArgumentNullException. Use ordinal in for type parameter names.
This was referenced Jan 20, 2023
This was referenced Jan 27, 2023
Conflicts resolved: - MoreLinq/EquiZip.cs - MoreLinq/Extensions.g.cs - MoreLinq/ZipLongest.cs - MoreLinq/ZipShortest.cs
Fixes following error:
EXEC : error : Error running transform: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
---> System.IO.FileLoadException: Could not load file or assembly 'System.Collections, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The parameter is incorrect. (0x80070057 (E_INVALIDARG))
File name: 'System.Collections, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
---> System.ArgumentException: Path "System.Collections.dll" is not an absolute path. (Parameter 'assemblyPath')
at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)
at Mono.TextTemplating.TemplateAssemblyLoadContext.Load(AssemblyName assemblyName) in /_/Mono.TextTemplating/Mono.TextTemplating/TemplateAssemblyLoadContext.cs:line 57
at System.Runtime.Loader.AssemblyLoadContext.ResolveUsingLoad(AssemblyName assemblyName)
at System.Runtime.Loader.AssemblyLoadContext.Resolve(IntPtr gchManagedAssemblyLoadContext, AssemblyName assemblyName)
at System.Linq.Enumerable.Range(Int32 start, Int32 count)
at Microsoft.VisualStudio.TextTemplating5ca31a7.GeneratedTextTransformation.TransformText()
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
--- End of inner exception stack trace ---
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
at Mono.TextTemplating.CompiledTemplate.TemplateProcessor.CreateAndProcess(ITextTemplatingEngineHost host, CompiledAssemblyData templateAssemblyData, String templateAssemblyFile, String fullName, CultureInfo culture, String[] referencedAssemblyFiles) in /_/Mono.TextTemplating/Mono.TextTemplating/CompiledTemplate.TemplateExecutor.cs:line 78
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
==========================================
- Coverage 92.49% 90.47% -2.03%
==========================================
Files 113 113
Lines 3424 3506 +82
Branches 1024 1055 +31
==========================================
+ Hits 3167 3172 +5
- Misses 192 265 +73
- Partials 65 69 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #639 since I erroneously deleted it's branch.