Minimum viable changes for Windows build

This + PRs substrait-io#109 and substrait-io#108 should be sufficient for a minimum-viable Windows (MSVC) build of this project.
mortbopet · Sep 4, 2024 · 34e3f28 · 34e3f28
1 parent 1dbf98b
commit 34e3f28
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/substrait/textplan/PlanPrinterVisitor.cpp b/src/substrait/textplan/PlanPrinterVisitor.cpp
@@ -1,7 +1,12 @@
 /* SPDX-License-Identifier: Apache-2.0 */
 
 #include "substrait/textplan/PlanPrinterVisitor.h"
+
+#ifdef _WIN32
+#include <io.h>
+#else
 #include <unistd.h>
+#endif
 
 #include <sstream>
 #include <string>

diff --git a/src/substrait/textplan/converter/SaveBinary.cpp b/src/substrait/textplan/converter/SaveBinary.cpp
@@ -7,8 +7,14 @@
 #include <google/protobuf/io/zero_copy_stream_impl.h>
 #include <google/protobuf/text_format.h>
 #include <google/protobuf/util/json_util.h>
+
+#ifdef _WIN32
+#include <io.h>
+#else
 #include <sys/fcntl.h>
 #include <sys/stat.h>
+#endif
+
 #include <fstream>
 
 #include "substrait/proto/plan.pb.h"