Skip to content

Commit

Permalink
Minimum viable changes for Windows build
Browse files Browse the repository at this point in the history
This + PRs substrait-io#109 and substrait-io#108 should be sufficient for a minimum-viable Windows (MSVC) build of this project.
  • Loading branch information
Morten Borup Petersen authored and mortbopet committed Sep 4, 2024
1 parent 1dbf98b commit 34e3f28
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/substrait/textplan/PlanPrinterVisitor.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
/* SPDX-License-Identifier: Apache-2.0 */

#include "substrait/textplan/PlanPrinterVisitor.h"

#ifdef _WIN32
#include <io.h>
#else
#include <unistd.h>
#endif

#include <sstream>
#include <string>
Expand Down
6 changes: 6 additions & 0 deletions src/substrait/textplan/converter/SaveBinary.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,14 @@
#include <google/protobuf/io/zero_copy_stream_impl.h>
#include <google/protobuf/text_format.h>
#include <google/protobuf/util/json_util.h>

#ifdef _WIN32
#include <io.h>
#else
#include <sys/fcntl.h>
#include <sys/stat.h>
#endif

#include <fstream>

#include "substrait/proto/plan.pb.h"
Expand Down

0 comments on commit 34e3f28

Please sign in to comment.