feat: add remove context command #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mflagey
force-pushed
the
60-feat-remove-context-command
branch
from
b7b5cc4 to
1ecc135
Compare
thomasgouveia
requested changes
Apr 25, 2023
Comment on lines
+92
to
+94
| if name == "localhost" { | ||
| return ErrRemoveDefaultContext | ||
| } |
There was a problem hiding this comment.
Why block the remove of the default context ? For me every context can be deleted. It does not make sense to block just this one.
Also, please ensure that there is no error if a user removes all the contexts. In that case, the default context should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.