Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XLA support #2964

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Update XLA support #2964

merged 7 commits into from
Feb 22, 2024

Conversation

bfontain
Copy link
Contributor

@bfontain bfontain commented Feb 5, 2024

What does this PR do?

This change contains a few small updates to XLA support in composer:

  1. Updates initialization to add required init_method argument for xla.
  2. Inserts a 'xm.mark_step()' call in the microbatching loop to prevent unrolling of microbatching.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@bfontain bfontain requested a review from dakinggg February 5, 2024 18:36
@bfontain bfontain requested a review from j316chuck February 12, 2024 22:43
composer/utils/dist.py Outdated Show resolved Hide resolved
@bfontain bfontain requested a review from j316chuck February 14, 2024 17:15
@bfontain bfontain enabled auto-merge (squash) February 22, 2024 18:50
@bfontain bfontain merged commit c0a9697 into mosaicml:dev Feb 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants