Remove "generation_length" in favor of "generation_kwargs" #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
Feb 16, 2024
maxisawesome
commented
Feb 21, 2024
maxisawesome
commented
Feb 21, 2024
dakinggg
reviewed
Feb 21, 2024
dakinggg
approved these changes
Feb 27, 2024
j316chuck
pushed a commit
that referenced
this pull request
Mar 29, 2024
* kill generation_length * fix tests * fix test * add deprecation warning * fix test * add gen_len back into static_keys * simplify setting variable in forward and add test * simply test * trailing comma * trailing comma * linting --------- Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
* kill generation_length * fix tests * fix test * add deprecation warning * fix test * add gen_len back into static_keys * simplify setting variable in forward and add test * simply test * trailing comma * trailing comma * linting --------- Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
KILLS :bufo-knife:
generation_lengthand sets it directly tomax_new_tokensingeneration_kwargs