-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for neuron devices #3049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j316chuck
reviewed
Feb 22, 2024
j316chuck
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Thanks for this! Overall LGTM barring nits
bfontain
changed the title
add initial support for neuron devices
Add initial support for neuron devices
Feb 23, 2024
j316chuck
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this device @bfontain
j316chuck
pushed a commit
that referenced
this pull request
Mar 29, 2024
* add initial support for neuron devices * add missing device_neuron.py * remove unused imports * update neuron flops * formatting * formatting * formatting * documentation * formatting
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
* add initial support for neuron devices * add missing device_neuron.py * remove unused imports * update neuron flops * formatting * formatting * formatting * documentation * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add some initial support for neuron devices to composer using the pytorch xla backend.
This PR fixes a few issues:
Tested using a small model on 2 neuron cores via torchrun. support for composer CLI to come.
What issue(s) does this change relate to?
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)