Skip to content

Commit

Permalink
Minor fixes to imports/ comments
Browse files Browse the repository at this point in the history
  • Loading branch information
umesh-timalsina committed Apr 26, 2022
1 parent d453e1f commit 279ca7e
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions gmso/core/forcefield.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from lxml import etree

from gmso.core.element import element_by_symbol
from gmso.exceptions import MissingPotentialError
from gmso.utils._constants import FF_TOKENS_SEPARATOR
from gmso.utils.ff_utils import (
Expand Down Expand Up @@ -109,16 +110,14 @@ def __init__(self, xml_loc=None, strict=True, greedy=True):
@property
def non_element_types(self):
"""Get the non-element types in the ForceField."""
from gmso.core.element import element_by_symbol

non_element_types = set()

for name, atom_type in self.atom_types.items():
element_symbol = atom_type.get_tag("element")
element_symbol = atom_type.get_tag(
"element"
) # FixMe: Should we make this a first class citizen?
if element_symbol:
element = element_by_symbol(
element_symbol
) # FixMe: Should we make this a first class citizen?
element = element_by_symbol(element_symbol)
non_element_types.add(None if element else element_symbol)

non_element_types.discard(None)
Expand Down

0 comments on commit 279ca7e

Please sign in to comment.