-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add non_element_types support for atomtyping #648
Feature: Add non_element_types support for atomtyping #648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few QOL changes, but I think mostly @bc118 has to test this one.
04aa961
to
fbbfdd4
Compare
79bfc3c
to
3102e66
Compare
Codecov Report
@@ Coverage Diff @@
## develop #648 +/- ##
===========================================
- Coverage 90.78% 90.51% -0.28%
===========================================
Files 56 56
Lines 4633 4585 -48
===========================================
- Hits 4206 4150 -56
- Misses 427 435 +8
Continue to review full report at Codecov.
|
This will fix an issue @bc118 ran into while testing #644.
Currently, in #644, we don't explicitly consider the non-element atomtypes while constructing an
AtomTypingRulesProvider
for foyer. This PR attempts to provide that support by explicitly adding that property to the forcefield.