-
Notifications
You must be signed in to change notification settings - Fork 688
[move-analyzer] Enhancement for supporting MSL and completion suggestions #930
base: sui-move
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a really large PR. I would strongly suggest splitting it into separate PRs, dealing with separate issues mentioned in the PR description.
A more detailed description of changes/additions/enhancements would also be greatly appreciated to ease the burden or reviewing the new code. In particular, it would be great to have a better idea of what the enhancements to the existing features are.
It also looks like some differences are solely due to different formatting. It would be great to have those unified with how it was formatted previously to emphasize portions of the code that have really changed.
Yes, it's a big PR, we considered splitting it before submitting it but not succeeded. We'd like to try to split it again, and fixing the format issues, and also add more description about the changes/additions/enhancements. For the splitting work, we may take some time to finish and submit separate PRs. Before that, we appreciate any reviews and comments on this PR. |
Thank you! I would really hope that it can be split considering that it addresses multiple somewhat separate issues. It would really help with the reviewing effort (I am assuming you tried stacked diffs), as would additional documentation/description (ideally in the code itself so that it's easy to find afterwards). There is also a lot of new functionality but very few tests... |
The toolchain been modified because of I have the error below.
It's wired, should impossible, Someone must used this version on Mac. |
We were admittedly rather tied up with the mainnet launch until recently, but it's time to get back to enhancing the IDE! I was wondering if there is any progress on (any of) the following:
|
we are still working on that, will keep you posted |
Do you have some kind of timeline in mind that you could share? |
Motivation
This is a draft PR for #799 from MoveBit, we'd like to let folks know what we're doing, and have a discussion with developers to improve move-analyzer together.
The changelog is below:
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested in our dev member's daily work, may not be fully tested.