Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Humble] Use same Docker CI actions as main #3098

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[Humble] Use same Docker CI actions as main #3098

merged 2 commits into from
Nov 15, 2024

Conversation

sea-bass
Copy link
Contributor

Description

Turns out the moveit/moveit2:humble-*** images have not been pushed in 7 months.

https://hub.docker.com/r/moveit/moveit2/tags

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify Mergify
Copy link

mergify bot commented Nov 15, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@sea-bass sea-bass changed the title [Humble] Use same Docker actions as main [Humble] Use same Docker CI actions as main Nov 15, 2024
sjahr
sjahr approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 Damn, thanks for addressing this

@sea-bass
Copy link
Contributor Author

I'm going to go ahead and merge this to see if it pushes to docker hub.

@sea-bass sea-bass merged commit a5de4e4 into humble Nov 15, 2024
11 checks passed
@sea-bass sea-bass deleted the humble-release-ci branch November 15, 2024 15:29
@sea-bass
Copy link
Contributor Author

I'm going to go ahead and merge this to see if it pushes to docker hub.

It did not. I don't understand why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjahr sjahr sjahr approved these changes

@henningkayser henningkayser Awaiting requested review from henningkayser

@rhaschke rhaschke Awaiting requested review from rhaschke

@pac48 pac48 Awaiting requested review from pac48

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sea-bass @sjahr