Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward ports recent dockerfile changes on foxy #704

Merged
merged 5 commits into from
Sep 24, 2021

Conversation

vatanaksoytezer
Copy link
Contributor

@vatanaksoytezer vatanaksoytezer commented Sep 24, 2021

Forward port of dockerfile changes in #698. Unblocks moveit/moveit2_tutorials#120

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #704 (7d7267c) into main (cee20d6) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   54.14%   54.18%   +0.04%     
==========================================
  Files         192      192              
  Lines       20180    20180              
==========================================
+ Hits        10925    10932       +7     
+ Misses       9255     9248       -7     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.49% <0.00%> (+0.51%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.85% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee20d6...7d7267c. Read the comment docs.

.docker/ci-testing/Dockerfile Outdated Show resolved Hide resolved
.docker/source/Dockerfile Outdated Show resolved Hide resolved
.docker/source/Dockerfile Show resolved Hide resolved
- name: Build and Push
uses: docker/build-push-action@v2
with:
context: .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's neat, thanks @rhaschke

@rhaschke rhaschke merged commit d184714 into moveit:main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants