-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trajectory Cache Example For Refactor #940
Open
methylDragon
wants to merge
8
commits into
moveit:main
Choose a base branch
from
methylDragon:ch3/trajectory-cache-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Trajectory Cache Example For Refactor #940
methylDragon
wants to merge
8
commits into
moveit:main
from
methylDragon:ch3/trajectory-cache-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <methylDragon@gmail.com>
This was referenced Aug 7, 2024
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/trajectory-cache-refactor
branch
2 times, most recently
from
August 9, 2024 04:36
c7cfd22
to
aa77650
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/trajectory-cache-refactor
branch
4 times, most recently
from
August 12, 2024 04:51
e9b3155
to
939b00c
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/trajectory-cache-refactor
branch
6 times, most recently
from
August 13, 2024 02:26
a2d1a11
to
9b6b6d7
Compare
methylDragon
force-pushed
the
ch3/trajectory-cache-refactor
branch
from
August 20, 2024 02:59
9b6b6d7
to
ae5f747
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/trajectory-cache-refactor
branch
from
August 20, 2024 03:01
ae5f747
to
3f05818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on top of, and is related to:
In the same way that
This PR changes the demo code to support the TrajectoryCache refactor.
It also ADDS VIDEOS AND IMAGES.
Setup
Running
NOTE: Sometimes a randomly generated demo goal is unreachable (or there's a weird move_group issue). Just restart the demo to resolve the issue.
Demo
The demo is a 4-phase demo. Hit
next
on the rviz visual tools dialog to advance the demo!See video: It showcases cache population, pruning, and fetching (4x speed)
For (4), you should see the robot arm "snap" to the fetched trajectory. The diff of the robot's start position to the trajectory is visualized in red to be obvious.
Screenrecording2024-07-3012.33.03AM-ezgif.com-crop-video.2.webm
Additional Notes
PS: I fully recognize that the template instantiations can look a bit intimidating.
e.g.
These can be mitigated by using declarations to carve out the namespaces. But I left it in for explanatory purposes.
(example cleaned up version)