Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoveGroup naming inconsitency #965

Closed
wants to merge 1 commit into from

Conversation

alejandrojginerd
Copy link

The MoveGroup name in hello_moveit.cpp does not match the one sued in panda.srdf, leading to errors while running ros2 run hello_moveit hello_moveit

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

The MoveGroup name in hello_moveit.cpp does not match the one sued in panda.srdf, leading to errors while running `ros2 run hello_moveit hello_moveit`
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main branch of this repo uses a Kinova robot which does have a manipulator group name.

I think this change is not needed, but is just a product of the robot model changing from Humble to later versions.

@mikeferguson
Copy link

Same change seems to have been suggested in a second PR here - #978 - is there something deeper going on?

@sea-bass
Copy link
Contributor

sea-bass commented Nov 8, 2024

Same change seems to have been suggested in a second PR here - #978 - is there something deeper going on?

I think it's just that the default page that pops up for the tutorials is main, where the tutorials use a Kinova robot with a manipulator group.

However, users on humble still have their tutorials using a Franka robot with a panda_arm group.

One other issue with all this is when you go to https://moveit.picknik.ai, there is no drop-down to change the docs version. You just have to change the URL from main to humble and the right material will appear.

Compare:

@sea-bass sea-bass closed this Nov 8, 2024
@sea-bass sea-bass mentioned this pull request Nov 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants