WIP Separate geometric properties of robot #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...from grasp generation tuning parameters
The file ROBOT_grasp_data.yaml should only contain geometry information about a specific robot. All the other parameters about grasp generation should go in the
moveit_grasp_config.yaml
. This has always bothered me, but its never been addressed because it affects all robots using this library.I'll continue to push on this, but wanted buy-in first from @mlautman @henningkayser
In this PR, all I have done is re-ordered the parameters into two sections: Grasping and Hand parameters. I'm proposing to then move the grasping parameters out of this file:
Proposal to move to moveit_grasp_config.yaml:
A next step, in an ideal world, is to actually move all the remaining parameters in this file into the SRDF spec, under the tag. But that's for another debate some other time...