Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove telemetry_sync_v5 #422

Closed

Conversation

acmiyaguchi
Copy link
Contributor

sync v5 was a mistake, as per bug 1410145. There is a surprising number of pings that are arriving on this doc version though (https://sql.telemetry.mozilla.org/queries/64998/source).

We should remove this table from the BigQuery dataset too, since it's causing telemetry.sync to alias to telemetry.sync_v5.

@acmiyaguchi acmiyaguchi requested a review from whd September 24, 2019 21:02
@whd
Copy link
Member

whd commented Sep 24, 2019

CI is still failing on the third-party-modules change, for some reason.

Given the relatively high volume, I want somebody (@mreid-moz?) to make a policy decision that we can/should delete this table. We haven't sorted out #386 yet and probably won't for some time. In the current model, we will remove these tables in a mostly non-reversible fashion.

An alternative solution would be to special-case the sync ping unversioned view to point at v4. Absent any compelling reasons I prefer this approach, since it appears we're using a hard-coded view at the moment anyway.

mreid-moz added a commit to mozilla/bigquery-etl that referenced this pull request Oct 7, 2019
Per [this pr](mozilla-services/mozilla-pipeline-schemas#422) and [Bug ](https://bugzilla.mozilla.org/show_bug.cgi?id=1572744), we should be using version `4` of the sync ping table for the unqualified table (rather than `v5`).
@mreid-moz
Copy link
Contributor

Either way, we need to fix the view to point to v4, so I sent mozilla/bigquery-etl#401.

I've asked for confirmation on deleting the data (as well as adding my understanding of the implications) in Bug 1572744#c4.

jklukas pushed a commit to mozilla/bigquery-etl that referenced this pull request Oct 7, 2019
Per [this pr](mozilla-services/mozilla-pipeline-schemas#422) and [Bug ](https://bugzilla.mozilla.org/show_bug.cgi?id=1572744), we should be using version `4` of the sync ping table for the unqualified table (rather than `v5`).
@acmiyaguchi
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants