feat: store remote-settings attachments in local storage #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
approved these changes
Nov 22, 2024
gruberb
force-pushed
the
store-attachments
branch
from
aca3713
to
dca08e2
Compare
gruberb
force-pushed
the
store-attachments
branch
from
dca08e2
to
b356317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: https://bugzilla.mozilla.org/show_bug.cgi?id=1929659
Hooking up
attachmentsto thesqlitestorage in the remote-settings component.I also changed the name of the
Attachmentstruct toAttachmentMetadata. I tried to do the same for theRemoteSettingsRecord, but we had to do some serialziation magic, and it seemed to cumbersome just for renaming things.The idea is to be intentional that what's part of the
RemoteSettingsRecordis not theattachmentitself, but just the metadata for anattachment. The Remote Settings server response is calling itattachment, and therefore we adopt the name here as well.