-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add related files to set Freshness and Volume on all glean tables #6296
base: main
Are you sure you want to change the base?
Conversation
@scholtzan should we change the schedule? |
This comment has been minimized.
This comment has been minimized.
sql_generators/glean_usage/common.py
Outdated
@@ -15,7 +15,7 @@ | |||
from bigquery_etl.schema.stable_table_schema import get_stable_table_schemas | |||
from bigquery_etl.util.common import get_table_dir, render, write_sql | |||
|
|||
APP_LISTINGS_URL = "https://probeinfo.telemetry.mozilla.org/v2/glean/app-listings" | |||
APP_LISTINGS_URL = "https://probeinfo.telemetry.mozilla.org/v2/glean/app-listings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APP_LISTINGS_URL = "https://probeinfo.telemetry.mozilla.org/v2/glean/app-listings" | |
APP_LISTINGS_URL = "https://probeinfo.telemetry.mozilla.org/v2/glean/app-listings" |
predefined_metric: FRESHNESS | ||
metric_schedule: | ||
named_schedule: | ||
name: Default Schedule - 17:00 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: Default Schedule - 17:00 UTC | |
name: Default Schedule - 13:00 UTC |
predefined_metric: VOLUME | ||
metric_schedule: | ||
named_schedule: | ||
name: Default Schedule - 17:00 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: Default Schedule - 17:00 UTC | |
name: Default Schedule - 13:00 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind changing this also here:
bigquery-etl/bigquery_etl/cli/monitoring.py
Line 176 in d741403
name="Default Schedule - 17:00 UTC" |
4fad505
to
b37b0e4
Compare
Integration report for "Merge branch 'main' into add_bigconfig_yaml_glean"
|
The PR add bigconfig yaml files to set Freshness and Volume on all glean tables.
Checks are configured to be run at
Default Schedule - 17:00 UTC
┆Issue is synchronized with this Jira Task