Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pocket): adding in pocket dbt datasets #6574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bassrock
Copy link

@bassrock bassrock commented Nov 27, 2024

Description

This PR adds datasets and necessary permissions for Pocket to begin building its existing models in DBT as we look at moving from Snowflake.

Related Tickets & Documents

Reviewer, please follow this checklist

┆Issue is synchronized with this Jira Task

Copy link
Member

@whd whd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM except for the lint issues and the note about needing all non-user-facing datasets to be suffixed with _derived or _external.

@@ -0,0 +1,17 @@
friendly_name: Pocket DBT Derived Snowplow Models
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these files are failing yaml lint.

@@ -0,0 +1,16 @@
friendly_name: Pocket DBT Fact Models
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently require every dataset that's not user_facing to be suffixed with _derived or _external. If that's a problem for DBT we can specifically configure these datasets but it will require the configure to be special case defined in https://github.com/mozilla-services/cloudops-infra/blob/master/projects/data-shared/tf/prod/envs/prod/bigquery-new/namespaces.auto.tfvars.json as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants