Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc page for serp events #803

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add doc page for serp events #803

merged 1 commit into from
Jan 26, 2024
+524 −0

Conversation

dzeber
Copy link
Contributor

@dzeber dzeber commented Dec 6, 2023

Adding a page describing the serp events themselves and the serp_events table.

I wrote 1 table in raw HTML so that I could get row headers spanning multiple rows.

@dzeber dzeber requested a review from pissac17 December 6, 2023 19:28
pissac17
pissac17 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@pissac17 pissac17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badboy
Copy link
Member

badboy commented Jan 26, 2024

rebased to avoid merge conflict.

@badboy badboy enabled auto-merge (rebase) January 26, 2024 10:03
@badboy badboy merged commit 49146e2 into main Jan 26, 2024
9 checks passed
@badboy badboy deleted the serp-events branch January 26, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissac17 pissac17 pissac17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzeber @badboy @pissac17