Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for v2 serp_events table #824

Merged
merged 3 commits into from
May 10, 2024
Merged

Update docs for v2 serp_events table #824

merged 3 commits into from
May 10, 2024

Conversation

dzeber
Copy link
Contributor

@dzeber dzeber commented May 1, 2024

No description provided.

@dzeber dzeber requested review from jaredsnyder and pissac17 May 1, 2024 00:43
jaredsnyder
jaredsnyder requested changes May 1, 2024
View reviewed changes
Copy link

@jaredsnyder jaredsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I ran all the example queries on mozdata.analysis.dzeber_serp_v2 and they worked great. A few issues but they're all style things, and a couple clarifying questions

src/datasets/other/serp_events/reference.md Outdated Show resolved Hide resolved
src/datasets/other/serp_events/reference.md Outdated Show resolved Hide resolved
src/datasets/other/serp_events/reference.md Outdated Show resolved Hide resolved
src/datasets/other/serp_events/reference.md Outdated Show resolved Hide resolved
src/datasets/other/serp_events/reference.md Show resolved Hide resolved
src/datasets/other/serp_events/reference.md Show resolved Hide resolved
jaredsnyder
jaredsnyder approved these changes May 2, 2024
View reviewed changes
Copy link

@jaredsnyder jaredsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dzeber dzeber marked this pull request as ready for review May 10, 2024 15:39
@dzeber dzeber merged commit eb135d0 into main May 10, 2024
9 checks passed
@dzeber dzeber deleted the serp-events-v2 branch May 10, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredsnyder jaredsnyder jaredsnyder approved these changes

@pissac17 pissac17 Awaiting requested review from pissac17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzeber @jaredsnyder