Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DENG 4918 Docs update for autogenerated data checks #847

Merged

Conversation

lucia-vargas-a
Copy link
Contributor

Updated docs after implementing DENG-4918.

@lucia-vargas-a lucia-vargas-a enabled auto-merge (squash) September 24, 2024 16:22
@@ -165,10 +158,28 @@ We need these changes:

## Validations

Recommended data validations include:
##### Automated validations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a nit and subjective but the five #'s make the text smaller than regular text so I would recommend going with the ### so it stands out. Also applies to the section below and there are some sections above with #####

Suggested change
##### Automated validations
### Automated validations

Copy link
Contributor Author

@lucia-vargas-a lucia-vargas-a Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! updated in a follow up PR-849

@lucia-vargas-a lucia-vargas-a merged commit 4cdad76 into main Sep 24, 2024
9 checks passed
@lucia-vargas-a lucia-vargas-a deleted the DENG-4918_docs_update_for_autogenerated_data_checks branch September 24, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants