Add Firefox major version support (#668) #675
Conversation
|
Test cases and test data added @whimboo |
tests/data/firefox/releases/23.0/win32/en-US/Firefox Setup 23.0.exe
Outdated
Show resolved
Hide resolved
… case with loren ipsum
…ase test case with 23.1.0
…0 version candidates
…idate test cases with 23.1.0
|
Added 23.1.0 test data, add test cases @whimboo |
| ({'platform': 'win32', 'version': '23'}, | ||
| 'firefox-23.1.0.en-US.win32.exe', | ||
| 'firefox/releases/23.1.0/win32/en-US/Firefox Setup 23.1.0.exe'), | ||
| ({'platform': 'win32', 'version': '23.0'}, |
There was a problem hiding this comment.
Hm, for this specific test I would actually expect that the 23.0.1 release would be downloaded which is the latest security release of the 23.0 minor version. And we have this release already present for the testing data.
There was a problem hiding this comment.
Oh, this change because I added 23.1.0 test data to the folder, so 23 ==> 23.1.0 instead of 23.0.1
There was a problem hiding this comment.
Well, the test doesn't specify 23 but is more strict in requesting a version for 23.0. That means that we cannot allow a download of 23.1.x but have to stick to the minor version which is 23.0.x and as such we still need to return 23.0.1.
|
Hi @piri-p. I wanted to check back with you and ask if you may have the time to finish this particular PR. Thanks. |
|
Hi @piri-p. If you aren't able to complete this PR would it be fine if someone else finishes it up? Thanks! |
Fix #668 - Add Firefox major version support @whimboo