[AMO validation] # is not a valid JS comment character (Issue #133)

[tonymec]

No description provided.

[tonymec]

@whimboo : r?

[xabolcs]

Hmm, tonymec:master seems to be outdated. :-/
You based the patch on commit 1dfa467 which is very outdated - it's MPL1.1.

If you would keep this pull, then you should merge in mozilla/master, or simply close this request and rebase this two changeset.

[tonymec]

Ah, sorry, it told me it was up-to-date. About MPL 1.1: that's the license AMO says we're using.

[xabolcs]

And please use * like in the other js files:

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

[whimboo]

Ah, sorry, it told me it was up-to-date. About MPL 1.1: that's the license AMO says we're using.

Really? I have updated the AMO entry yesterday to MPL 2. Might be it will update it with the not yet reviewed 3.5 release.

[xabolcs]

Really? I have updated the AMO entry yesterday to MPL 2. Might be it will update it with the not yet reviewed 3.5 release.

For the currently displayed 3.4 AMO says:

Source code released under Custom License

For the currently queued 3.5 AMO says:

Source code released under Mozilla Public License, version 2.0

And the relicense was done by #39 and #98 (landed in v3.4).

[whimboo]

Looks like you cannot change the license for older entries but it only applies to the current one. So we cannot change this anymore. I wouldn't worry that much about it.

[tonymec]

Yeah, apparently I wasn't up-to-date on that either.