-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump android-sdk-ui from 24.3.0 to 25.0.0 #133
chore: bump android-sdk-ui from 24.3.0 to 25.0.0 #133
Conversation
Can someone please take a look at this? |
Apologies for the delay on this. We'll need to do some testing to confirm there are no breaking changes since it's a major version bump, then we can merge this. |
Thanks @einsteinx2 😄 I don't believe that any breaking changes have been made in v25.0.0 https://www.braze.com/docs/developer_guide/platform_integration_guides/android/changelog/#2500 There however were breaking changes in v26.0.0 https://www.braze.com/docs/developer_guide/platform_integration_guides/android/changelog/#2600 |
3d6f516
into
mparticle-integrations:development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
* fix: Manually adding custom attributes for NON PURCHASE EVENTS (#147) * Manually adding custom attributes for NON PURCHASE EVENTS * Adding commented test * fix: Forward Custom Attributes for all Commerce Events (#150) * feat: SQDSDKS-5551 Changing test for sideloading kits feature (#151) Fixing test to accomodate new architecture change for sideloaded kits * chore: bump android-sdk-ui from 24.3.0 to 25.0.0 (#133) :arrow_up: Upgrade Braze Android SDK from v24 to v25 * fix: flip supportsAttributeLists back to true (#162) Signed-off-by: jshin-tse <107695224+jshin-tse@users.noreply.github.com> * Bumping min version to API 21 based on Braze documentation Bumping to latest Braze version --------- Signed-off-by: jshin-tse <107695224+jshin-tse@users.noreply.github.com> Signed-off-by: markvdouw <v-mvanderouw@mparticle.com> Co-authored-by: Brandon Stalnaker <33703490+BrandonStalnaker@users.noreply.github.com> Co-authored-by: Klemen Tusar <techouse@gmail.com> Co-authored-by: jshin-tse <107695224+jshin-tse@users.noreply.github.com>
Summary
The recently released Braze Android SDK v25 is now hosted on Maven Central which means that
repositories { maven { url "https://appboy.github.io/appboy-android-sdk/sdk" } }
can now be removed from
build.gradle
.Also, the dependency name has been renamed from
'com.appboy:android-sdk-ui'
to
'com.braze:android-sdk-ui'
Testing Plan
android-appboy-kit-release.aar
. Works OK.