Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forward Custom Attributes for all Commerce Events #150

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • An earlier revert undid support for Custom Attributes for purchase events so when it was added for non-purchase events that regression was discovered

Testing Plan

  • Tested locally and through unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@markvdouw markvdouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks a lot!

@markvdouw markvdouw merged commit 5395cbc into development Jul 17, 2023
16 checks passed
@markvdouw markvdouw deleted the fix/5170-Forward-Custom-Attributes-For-All-Commerce-Events branch July 17, 2023 23:50
markvdouw added a commit that referenced this pull request Dec 21, 2023
* fix: Manually adding custom attributes for NON PURCHASE EVENTS (#147)

* Manually adding custom attributes for NON PURCHASE EVENTS

* Adding commented test

* fix: Forward Custom Attributes for all Commerce Events (#150)

* feat: SQDSDKS-5551 Changing test for sideloading kits feature (#151)

Fixing test to accomodate new architecture change for sideloaded kits

* chore: bump android-sdk-ui from 24.3.0 to 25.0.0 (#133)

:arrow_up: Upgrade Braze Android SDK from v24 to v25

* fix: flip supportsAttributeLists back to true (#162)

Signed-off-by: jshin-tse <107695224+jshin-tse@users.noreply.github.com>

* Bumping min version to API 21 based on Braze documentation
Bumping to latest Braze version

---------

Signed-off-by: jshin-tse <107695224+jshin-tse@users.noreply.github.com>
Signed-off-by: markvdouw <v-mvanderouw@mparticle.com>
Co-authored-by: Brandon Stalnaker <33703490+BrandonStalnaker@users.noreply.github.com>
Co-authored-by: Klemen Tusar <techouse@gmail.com>
Co-authored-by: jshin-tse <107695224+jshin-tse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants