Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SQDSDKS-5551 Changing test for sideloading kits feature #91

Merged
merged 1 commit into from
Jul 20, 2023
Merged

feat: SQDSDKS-5551 Changing test for sideloading kits feature #91

merged 1 commit into from
Jul 20, 2023

Conversation

markvdouw
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Changing test for sideloading kits feature

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

einsteinx2
einsteinx2 approved these changes Jul 19, 2023
View reviewed changes
Copy link

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markvdouw markvdouw merged commit ca86391 into development Jul 20, 2023
17 checks passed
@markvdouw markvdouw deleted the feat/SQDS-5551_fix_sideloaded_integration branch July 20, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@rmi22186 rmi22186 Awaiting requested review from rmi22186

@BrandonStalnaker BrandonStalnaker Awaiting requested review from BrandonStalnaker

@alexs-mparticle alexs-mparticle Awaiting requested review from alexs-mparticle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@markvdouw @einsteinx2 @rmi22186 @BrandonStalnaker @alexs-mparticle