fix: Update allowable character limits and number of attributes for GA360 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
reviewed
Feb 5, 2024
| @@ -44,10 +44,10 @@ @implementation MPKitFirebaseGA4Analytics | |||
|
|
|||
| const NSInteger FIR_MAX_CHARACTERS_EVENT_NAME = 40; | |||
| const NSInteger FIR_MAX_CHARACTERS_IDENTITY_NAME = 24; | |||
| const NSInteger FIR_MAX_CHARACTERS_EVENT_ATTR_VALUE = 100; | |||
| const NSInteger FIR_MAX_CHARACTERS_EVENT_ATTR_VALUE = 500; | |||
There was a problem hiding this comment.
I would add a comment at the top of this block stating that the below constants are based off of Google's 360 plan limits, and link to https://support.google.com/analytics/answer/11202874?sjid=14644072134282618832-NA#limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current GA4 kit data limits for number of event attributes and item attributes are hardcoded for GA4's standard plan. For GA360 customers, their data limits are higher but we will drop attributes preemptively. We should hardcode for GA360 data limits and let Google drop the attributes if customers are on the Standard plan.
Testing Plan
No, we do not have access to a GA360 account, PR is just a change in the value of max attributes allowed.
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)