Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Google Consent #26

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Add support for Google's new consent feature

Testing Plan

  • Tested locally in sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Collaborator

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise seems fine, I don't know enough about the Consent feature to know if the logic is correct, I'll leave that to the others that worked on this.

Copy link

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consent Logic looks good to me.

@BrandonStalnaker BrandonStalnaker merged commit 78d898b into development Apr 2, 2024
3 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/6175-Support-Google-Consent branch April 2, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants