Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add product brand to ecommerce event products #28

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

v-mamaya
Copy link
Contributor

@v-mamaya v-mamaya commented Jun 7, 2024

Summary

We are adding the product brand to the ecommerce event logging to match the feature that web already has.

Testing Plan

  • Was this tested locally? If not, explain why.
    Manually tested via the Firebase debugger.
    Before change:
    Purchase
image

Impression
image

After change:

Purchase
image

Impression
image

Copy link
Collaborator

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit b7a19d4 into mparticle-integrations:development Jun 12, 2024
2 of 3 checks passed
mparticle-automation added a commit that referenced this pull request Jun 12, 2024
# [8.7.0](v8.6.0...v8.7.0) (2024-06-12)

### Features

* Add product brand to commerce event products ([#28](#28)) ([245e42f](245e42f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants