-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set MPID before open session #41
fix: Set MPID before open session #41
Conversation
@alexs-mparticl |
@alexs-mparticle Pushed the tests. Let me know if there's anything else that needs to be addressed on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Please remove the changes to dist and and package-lock.json. These will be handled as part of our release job.
dist/BrazeKit.common.js
Outdated
@@ -9172,7 +9172,7 @@ window.braze = require$$0; | |||
var name = 'Appboy', | |||
suffix = 'v4', | |||
moduleId = 28, | |||
version = '4.1.0', | |||
version = '4.1.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please undo this change. Our process is to update the version number and distribution as a separate commit when we release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems to already be in the master-v4 branch. I don't think it was a change that I made. Not sure I know how to roll it back in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, you may need to rebase your branch against master-v4
. I'll see if I can help you out with that.
dist/BrazeKit.iife.js
Outdated
@@ -9172,7 +9172,7 @@ var mpBrazeKitV4 = (function (exports) { | |||
var name = 'Appboy', | |||
suffix = 'v4', | |||
moduleId = 28, | |||
version = '4.1.0', | |||
version = '4.1.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please undo all changes in this file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is also already in the master-v4 branch.
package-lock.json
Outdated
@@ -6,7 +6,7 @@ | |||
"packages": { | |||
"": { | |||
"name": "@mparticle/web-braze-kit", | |||
"version": "4.0.1", | |||
"version": "4.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please roll this back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the git blame it says that you made the change in the master-v4 branch a few days ago. I could very well be confused about these changes.
getMPID: function () { | ||
return 'MPID123'; | ||
}, | ||
getUserIdentities: function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is getUserIdentities
a necessary addition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, it is necessary, yes. The getUserIdentities function is needed in the onUserIdentified call which sets the Braze identity. In retrospect, I'm calling the onUserIdentified function which in turn calls the Braze changeUser function. Seems like I could skip the secondary function and call the Braze function directly - would it make sense to make that change to eliminate the getUserIdentities and the extra processing?
61bdbed
to
26b4093
Compare
c416392
into
mparticle-integrations:master-v4
Summary
changeUser
viaonUserIdentified
beforeopenSession
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)
openSession
andchangeUser
)