ci: Add CI/CD and semantic release #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| </script> | |||
| <!-- change name of XYZ-Kit below to the name of your built kit--> | |||
| <script src="../build/DoubleClick-Kit.js"></script> | |||
| <script src="../dist/DoubleClick-Kit.iife.js"></script> | |||
There was a problem hiding this comment.
If you're changing the location of this file, shouldn't you also remove the old one?
alexs-mparticle
requested changes
Oct 2, 2023
.github/workflows/release.yml
Outdated
| - name: NPM install | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.x |
There was a problem hiding this comment.
Nit: Should we update this to a more recent version of node?
rmi22186
added a commit
that referenced
this pull request
Oct 2, 2023
ci: Update node version ci: Add scripts folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
We did not have semantic release on this kit. Since we don't update these kits too often, I wanted to implement this now. Most of this is pulled and adapted from GA4. For reference below:
Testing Plan
It is not possible to test a github action prior to release. However, if there are any failures, we can debugonce this file is in
master.Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)