-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add CI/CD and semantic release #43
Conversation
@@ -21,7 +21,7 @@ | |||
|
|||
</script> | |||
<!-- change name of XYZ-Kit below to the name of your built kit--> | |||
<script src="../build/DoubleClick-Kit.js"></script> | |||
<script src="../dist/DoubleClick-Kit.iife.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're changing the location of this file, shouldn't you also remove the old one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just remove the old build
directory and we should be good. Also, Maybe we can introduce a breaking change to verify that tests properly run?
.github/workflows/release.yml
Outdated
- name: NPM install | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: 16.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Should we update this to a more recent version of node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci: Update node version ci: Add scripts folder
Instructions
development
Summary
We did not have semantic release on this kit. Since we don't update these kits too often, I wanted to implement this now. Most of this is pulled and adapted from GA4. For reference below:
Testing Plan
It is not possible to test a github action prior to release. However, if there are any failures, we can debugonce this file is in
master
.Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)